This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix recursive reserve call in ProtoGC #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or to all gc_* calls from ProtoGC to clarify that they are the global functions.
|
Thanks for your pull request, @schveiguy! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Dammit, I just realized this should have targeted stable, I didn't realize Martin had forked after the ProtoGC thing was added. @MartinNowak can you cherry pick this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added global scope operator to all
gc_*calls fromProtoGCto clarify that they are the global functions and not members (would have potentially helped catch the original issue).See #2057 (comment)
Ping @somzzz @andralex @klickverbot @MartinNowak
I did not do anything about the race condition on the root/range lists, as I don't know the correct direction to choose there.