Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

nullptr_t not defined. #2175

Merged
merged 1 commit into from May 8, 2018
Merged

nullptr_t not defined. #2175

merged 1 commit into from May 8, 2018

Conversation

TurkeyMan
Copy link
Contributor

Added alias for nullptr_t, which is defined in stddef.h.

Note: DMD still doesn't mangle this properly with extern(C++)!

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2175"

@TurkeyMan
Copy link
Contributor Author

Surely this is uncontroversial...?

@jmdavis
Copy link
Member

jmdavis commented May 8, 2018

Surely this is uncontroversial...?

If that were why it hadn't been merged, there would be comments about it. Rather, I think that it's pretty clear that it's simply the case that it hasn't been looked at yet, because it's so new. It looks trivial enough though that I don't see any reason for me to not just merge it.

@WalterBright
Copy link
Member

because

... some of us are still traveling! I'm at Code Europe in Poland.

@TurkeyMan
Copy link
Contributor Author

Poland roxors!

@dlang-bot dlang-bot merged commit bd2ea42 into dlang:master May 8, 2018
@TurkeyMan TurkeyMan deleted the nullptr_t branch May 17, 2018 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants