Fix Issue 19049 - object.hashOf - don't wrap a public function with an identical public function

[n8sh]

This is hashOf in object.d:

size_t hashOf(T)(auto ref T arg, size_t seed = 0)
{
    import core.internal.hash;
    return core.internal.hash.hashOf(arg, seed);
}

This serves no purpose because core.internal.hash.hashOf is public and also has an auto ref argument. So core.internal.hash.hashOf should either be publicly imported or exposed through an alias.

This issue has synergy with PR #2238.

[dlang-bot]

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19049	enhancement	object.hashOf - don't wrap a public function with an identical public function

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2239"

[wilzbach]

Do we even need a body if it's for ddoc only? An empty body should work too?

[jacob-carlborg]

Should work.

[n8sh]

When I replace it with size_t hashOf(T)(auto ref T arg, size_t seed = 0); I get an error:

../dmd/generated/osx/release/64/dmd -conf= -c -w -o- -Isrc -Iimport -version=CoreDdoc -Dfdoc/object.html project.ddoc  src/object.d
src/object.d(1605): Error: function object.hashOf!(void delegate()).hashOf is not nothrow
src/object.d(1603): Error: nothrow function object.TypeInfo_Delegate.getHash may throw

[JinShil]

This PR may have caused a regression: https://issues.dlang.org/show_bug.cgi?id=19701