[stable] core.stdc.stdint: Fix some aliases for Windows/MSVC #2302
Conversation
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + druntime#2302" |
This was changed to |
alias uint8_t = ubyte; /// | ||
alias uint16_t = ushort; /// | ||
alias int32_t = cpp_long; /// | ||
alias uint32_t = cpp_ulong; /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O_o ... wow, wild ;)
Well this fails on Win32... |
I think the correct fix would be to split Win32 on DMC vs MSVC. |
I'm surprise it's not already that way.. |
Yeah, me too, but no wonder - I hate these crappy mangling tests using a hardcoded mangle:
Proper tests consist in a .cpp and a .d file and really make sure they can be linked... |
I have 2 follow-up fixes for |
For isolated tests like this, it's probably easiest to disable the failing tests in a preparatory PR, and then add them back once the fix is in. |
In VS 2017's
stdint.h
,int32_t
is a typedef forint
, notlong
; also verifiable on MSDN (incl. VS 2015). I haven't checked DMC for conformance.This also fixes one part of issue 19249.