This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Add support for the in operator in dassert #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2463" |
wilzbach
commented
Jan 14, 2019
| case "in": | ||
| return "!in"; | ||
| case "!in": | ||
| return "in"; |
There was a problem hiding this comment.
Technically !in isn't an operator like the others (and the DMD PR doesn't include this change), but if we ever end up supporting this, it would very likely use !in.
thewilsonator
approved these changes
Jan 14, 2019
|
PR needs rebased |
PetarKirov
force-pushed
the
assert-in
branch
from
50cd3b5
to
12eb53d
Compare
PetarKirov
approved these changes
Feb 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires dlang/dmd#9264