Removing __mbstate_t union definition from core/stdc/stdio.d

[rmboggs]

Both NetBSD and OpenBSD have _mbstate_t union definitions in both stdio.d and wchar.d files in src/core/std. Since _mbstate_t should be defined in wchar.d and __mbstate_t isn't used by Net/OpenBSD in stdio.d anyway, just remove the defs from stdio.d and it should be ok.

Please let me know if anything else needs to be modified.

[dlang-bot]

Thanks for your pull request and interest in making D better, @rmboggs! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2473"

[PetarKirov]

Thanks! Can you move the FreeBSD and DragonFlyBSD definitions to wchar_.d as well?

[ibuclaw]

LGTM, just noted comments to address.

[rmboggs]

I was wondering about the other BSDs, actually. The only reason why I left them as is was because I didn't know what else relied on mbstate being in stdio.d, for FreeBSD at least since it is a supported platform.

If you guys feel that such a change is safe, I'll do it. I'm just being cautious.

[ibuclaw]

Perhaps it should go in its own, but given a choice between the two, wchar_.d looks to be the better place to have the definition.

In stdio.d, just be sure to have import core.stdc.wchar_ : mbstate_t for the BSDs that use it.

[PetarKirov]

As far as I could see, in FreeBSD's libc implementation __mbstate_t is definited in <sys/_typses.h> and typedef-ed to mbstate_t in <wchar.h> More importantly, the C standard says that mbstate_t is definited by <wchar.h>, so the definition should go there (in core.sys.stdc.wchar_.d). And, as far as core.sys.stdc.stdio is concerned, it should only privately import core.stdc.wchar_ : mbstate_t and no users of stdio should assume that mbstate_t is exposed from there.

[rmboggs]

Ok, makes sense. I'll push an update as soon as I can. Thanks.

[ibuclaw]

The remaining odd one out looks to be Solaris, but I'm OK with handling that separately.

[rmboggs]

Ok, well. All the other BSDS are updated accordingly now. Please take a good look at the FreeBSD and DragonFlyBSD updates as I can't test those at home currently.

[PetarKirov]

Everything looks good to me, nice work!

[rmboggs]

Thanks, glad to help.

Do you still need me to refactor mbstate_t for solaris? Looking at the code, I thought that one was fine as-is.

[ibuclaw]

#2474