fix ldap bindings, fix issue 17248 #2603
Conversation
Looked up and corrected most LDAP methods: changed char* (PCHAR) arguments to const(char)* (PCSTR) where documentation say const Renamed some types like in the documentation (purely aesthetic) Fixed a PLDAPControlW actually being PLDAPControlA in an ASCII method Changed [] arguments to * (fixed the referenced issue)
|
Thanks for your pull request, @WebFreak001! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + druntime#2603" |
| ULONG ldap_unbind(LDAP*); | ||
| ULONG ldap_unbind_s(LDAP*); | ||
| ULONG ldap_search_extA(LDAP*, PCHAR, ULONG, PCHAR, PCHAR[], ULONG, | ||
| ULONG ldap_search_extA(LDAP*, PCSTR, ULONG, PCSTR, PZPSTR, ULONG, | ||
| PLDAPControlA*, PLDAPControlA*, ULONG, ULONG, ULONG*); |
There was a problem hiding this comment.
this was PLDAPControlW* before even though this is an A method (corrected it to what the docs said this type is)
|
Please merge when you have had a chance to test. |
The modrdn methods are obsolte as per documentation: https://docs.microsoft.com/en-us/windows/desktop/api/winldap/nf-winldap-ldap_modrdnA However the ldap_bind methods don't mention anything about deprecation: https://docs.microsoft.com/en-us/windows/desktop/api/winldap/nf-winldap-ldap_bindA I think the deprecation might have been added because of the "do not use" message, however you should only not use it if you aren't connected through an encrypted connection. You must use it to authenticate as a user on the server (as also shown in the code example)
|
I undeprecated the Otherwise usage works fine now, (connection works, etc.) the Also I don't have merge rights in this repo :p |
Looked up and corrected most LDAP methods:
changed
char*(PCHAR) arguments toconst(char)*(PCSTR) where documentation saysconst.Renamed some types to be the same as in the documentation. (purely aesthetic, fit in with adding the const to the parameters well)
Fixed a PLDAPControlW actually being PLDAPControlA in an ASCII method.
Changed
T[]arguments toT*(fixes the referenced issue)Did not test this with an actual connection yet. The definition is more like in my
ldappackage on dub now, which works for me.