Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

object.d: Move __ArrayEq to rt #2644

Merged
merged 1 commit into from Jun 17, 2019
Merged

object.d: Move __ArrayEq to rt #2644

merged 1 commit into from Jun 17, 2019

Conversation

JinShil
Copy link
Contributor

@JinShil JinShil commented Jun 17, 2019

Followup to #2634 and #2643

@JinShil JinShil marked this pull request as ready for review June 17, 2019 05:35
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2644"

@jacob-carlborg
Copy link
Contributor

Can this be merged or is there a DMD PR that needs to be merged first?

@JinShil
Copy link
Contributor Author

JinShil commented Jun 17, 2019

This is just a refactoring. It's just changing the location of the implementation within the druntime repository. There are no other changes required.

@dlang-bot dlang-bot merged commit 994cc5b into dlang:master Jun 17, 2019
@jacob-carlborg
Copy link
Contributor

I missed the public import in object.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants