This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
problem with signal handling and parallel GC on linux #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikod
requested review from
andralex,
DmitryOlshansky,
MartinNowak,
rainers and
wilzbach
as code owners
|
Thanks for your pull request and interest in making D better, @ikod! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + druntime#2813" |
rainers
reviewed
Oct 5, 2019
src/gc/impl/conservative/gc.d
Outdated
| @@ -2874,6 +2874,18 @@ struct Gcx | |||
|
|
|||
| void scanBackground() nothrow | |||
| { | |||
| version (posix) | |||
rainers
approved these changes
Oct 6, 2019
src/gc/impl/conservative/gc.d
Outdated
| version (Posix) | ||
| { | ||
| import core.sys.posix.signal; | ||
| // block all signals, scanThread inherits this mask. |
There was a problem hiding this comment.
I guess you mean scanBackground here.
test/gc/sigmaskgc.d
Outdated
| sigaddset(&m, SIGHUP); | ||
|
|
||
| auto x = new int[](10000); | ||
| for (int i=0; i<10000; i++) |
There was a problem hiding this comment.
code style nit: for (int i = 0; i < 10000; i++)
There was a problem hiding this comment.
Bonus for foreach (i; 0 .. 10000)
test/gc/sigmaskgc.d
Outdated
| auto parent_pid = getpid(); | ||
| auto child_pid = fork(); | ||
| assert(child_pid >= 0); | ||
| if ( child_pid == 0 ) |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://issues.dlang.org/show_bug.cgi?id=20256
Conservative GC scan threads do not block signals when created, which can lead to unexpected behaviour if developer have to block signals for whole process.
This PR fix issue by blocking all signals in conservative GC scanThreads.