This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
fix issue 20438 - [Reg 2.086] GC: memory not reusable when calling GC… #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainers
requested review from
andralex,
DmitryOlshansky,
MartinNowak and
wilzbach
as code owners
|
Thanks for your pull request, @rainers! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + druntime#2858" |
….collect after GC.free fix detection of page with unused allocation slots
|
buildkite failure is an unrelated connection error: |
thewilsonator
approved these changes
Dec 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….collect after GC.free
fix detection of page with unused allocation slots
What this bug means: if no object was collected in a page, and a quarter of the page had no free allocation slots, the whole page was considered to be used, so the free slots were not restored to the free lists.