This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 20468 - emplace should forward argument lvalueness correctly
#2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSoulaimane
requested review from
andralex,
MartinNowak,
schveiguy and
wilzbach
as code owners
|
Thanks for your pull request, @SSoulaimane! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2890" |
thewilsonator
approved these changes
Jan 2, 2020
SSoulaimane
force-pushed
the
forwardemplace
branch
from
0a3bec5
to
f8b2223
Compare
|
It's ready now. I put |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emplacepasses arguments by ref instead of usingforward, this fixes it.