Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 19902 - hasElaborateCopyConstructor doesn't know about copy… #2911

Merged
merged 1 commit into from Jan 20, 2020

Conversation

pbackus
Copy link
Contributor

@pbackus pbackus commented Jan 19, 2020

… constructors

Uses the new __traits from dlang/dmd#10528.

Previously: #2709

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19902 regression hasElaborateCopyConstructor doesn't know about copy constructors

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + druntime#2911"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jan 19, 2020
Copy link
Contributor

@edi33416 edi33416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TurkeyMan
Copy link
Contributor

There's no negative test in this PR. Regressions that produce false-positives may be missed.

@MoonlightSentinel
Copy link
Contributor

FYI: Phobos forwards to this implementation and has some additional tests, see https://github.com/dlang/phobos/blob/79cc44b8f5c25ea8be6a254171b17f3606465c1a/std/traits.d#L3665-L3686

@TurkeyMan
Copy link
Contributor

👍

@pbackus pbackus deleted the fix-19902 branch June 12, 2020 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
6 participants