This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix Issue 16658: Default IE version set to 6.0 #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE 4 it too old. As it only supports up to WinNT 4.0, it's not available on WinXP or even Win2k. This leads to a mismatch with the default `_WIN32_WINNT = 0x500` (WinXP) value. Make the default IE version set to 6.0 could make more APIs available at default. Also, DMD now supports only `Windows 7 or later, 32 or 64 bit` and Windows 7 has reached End Of Life on 14 January 2020, it could reasonably set default value to: `_WIN32_WINNT = 0x601` and `_WIN32_IE = 0x800`. But this topic should be discussed in another PR.
|
Thanks for your pull request and interest in making D better, @LimiQS! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2929" |
CyberShadow
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default IE version set to 6.0