Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Explicitly call _d_assert_fail in test/exceptions/assert_fail.d #3019

Merged
merged 1 commit into from Apr 7, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Apr 6, 2020

This test should only check the druntime component of -checkaction=context,
i.e. that _d_assert_fail yields an appropriate assert message. Using assert
directly linked this test to the lowering details and made changes changes
quite difficult because one cannot make changes to dmd and druntime in a
single PR (see e.g. dlang/dmd#11005).

CC @kinke, @wilzbach

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 6, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3019"

@kinke
Copy link
Contributor

kinke commented Apr 6, 2020

Thanks, that will definitely help; at some point, these tests can be turned to regular unittests (for miniformat etc. too). I'd need it in stable though.

This test should only check the druntime component of `-checkaction=context`,
i.e. that `_d_assert_fail` yields an appropriate assert message. Using `assert`
directly linked this test to the lowering details and made changes changes
quite difficult because one cannot make changes to dmd and druntime in a
single PR (see e.g.  dlang/dmd#11005).
@MoonlightSentinel
Copy link
Contributor Author

Rebased onto stable

@MoonlightSentinel
Copy link
Contributor Author

BuildKite fails because it uses dmd-master ...

@thewilsonator thewilsonator merged commit 8c84676 into dlang:stable Apr 7, 2020
@MoonlightSentinel MoonlightSentinel deleted the rework-assert-fail branch April 19, 2020 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants