Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20750 - checkaction=context segfaults for null references #3045

Merged
merged 1 commit into from Apr 19, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 19, 2020

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20750 minor checkaction=context segfaults for null references

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3045"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 19, 2020
@Geod24
Copy link
Member

Geod24 commented Apr 19, 2020

I can see this creating some bloat, though. But at the same time, trying to reduce the bloat will lead to issues with attributes.

@MoonlightSentinel MoonlightSentinel changed the base branch from master to stable April 19, 2020 12:08
@MoonlightSentinel
Copy link
Contributor Author

MoonlightSentinel commented Apr 19, 2020

Should this be inlined instead of an additional function?

EDIT: Amended to move the check inside of miniFormat

@MoonlightSentinel
Copy link
Contributor Author

Sqashed the inline changes into the first commit.

@dlang-bot dlang-bot merged commit b6f45c8 into dlang:stable Apr 19, 2020
@MoonlightSentinel MoonlightSentinel deleted the nullToString branch April 19, 2020 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
4 participants