Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 20757 - checkaction=context prints characters as integers #3057

Merged
merged 2 commits into from Apr 22, 2020

Conversation

MoonlightSentinel
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20757 minor checkaction=context prints characters as integers

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3057"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Apr 21, 2020
@schveiguy
Copy link
Member

It should check for invalid single code units, and print those as "cast(char)255" e.g. Otherwise, the string is going to look weird when printed (and might cause a UTF exception, I'm not sure).

@MoonlightSentinel
Copy link
Contributor Author

Done

src/core/internal/dassert.d Outdated Show resolved Hide resolved
@dlang-bot dlang-bot merged commit 83e75aa into dlang:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
4 participants