Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 20852: core.sys.posix.sys.wait missing definitions on FreeBSD #3115

Merged
merged 3 commits into from
May 24, 2020

Conversation

sakhmatd
Copy link
Contributor

Upon further testing with the Vibe.d test suite, it appears that the entire idtype_t
struct from sys/wait.h is required for some parts of eventcore to compile.
Thus, I reopened issue 20852.

This commit adds all of the missing id types.

After adding the missing id types, Vibe.d tests pass as intended.

I apologize for not testing the initial commit more thoroughly.

Upon further testing with the Vibe.d suite, it appears that the entire idtype_t
struct from sys/wait.h is required for some parts of eventcore to compile.

This commit adds all of the missing id types.

After adding the missing id types, Vibe.d tests pass as intended.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @sakhmatd! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20852 major core.sys.posix.sys.wait missing definitions on FreeBSD

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3115"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label May 24, 2020
@thewilsonator thewilsonator merged commit 5e37bce into dlang:master May 24, 2020
@sakhmatd sakhmatd deleted the wait-fbsd-2 branch May 24, 2020 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
3 participants