This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
TypeInfo.swap must not allow reachable memory to be freed if interrupted by a garbage collection pass #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @n8sh! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3264" |
… freed if interrupted by a garbage collection pass If the type might contain pointers perform the swap in pointer-sized chunks in case a garbage collection pass interrupts the function. Directly affected TypeInfo subclasses that were not overriding swap: - TypeInfo_AssociativeArray - TypeInfo_Class - TypeInfo_Delegate - TypeInfo_Interface - TypeInfo_Struct
thewilsonator
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type might contain pointers perform the swap in pointer-sized chunks in case a garbage collection pass occurs partway through the function. Directly affected TypeInfo subclasses that were not overriding swap: