Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

[stable] Allow detached threads to be joined on Windows too #3429

Merged
merged 1 commit into from Apr 4, 2021

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Apr 4, 2021

PR #3418 allowed them on Posix; extend it to Windows too. The added test/thread/src/join_detach.d test now passes on Windows (tested by LDC).

PR dlang#3418 allowed them on Posix; extend it to Windows too. The added
test/thread/src/join_detach.d test now passes on Windows (tested by
LDC).
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3429"

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@Geod24 Geod24 merged commit 89e2232 into dlang:stable Apr 4, 2021
@kinke kinke deleted the join_detached_win branch April 4, 2021 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants