This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is… #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @Chigusa0w0! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3457" |
|
please add the test case from the bug report |
|
@thewilsonator Test cases added |
|
finally can you retarget this PR to stable (follow the bot's instructions) and this should be good to go. |
thewilsonator
approved these changes
May 2, 2021
Chigusa0w0
force-pushed
the
patch-4
branch
2 times, most recently
from
c5f717f
to
042c004
Compare
Chigusa0w0
requested review from
Burgos,
CyberShadow,
ibuclaw,
rainers,
WalterBright and
wilzbach
as code owners
… using UB This is a quick fix to Issue 21363. When `count` is set to `0`, `T.sizeof * 8 - count` will always be `T.sizeof * 8` therefore fails compiler check here: https://github.com/dlang/dmd/blob/81f9f57257da8733cf741355524bb8a3ec9c45ce/src/dmd/dinterpret.d#L3018-L3024
|
@thewilsonator rebase done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… using UB
This is a quick fix to Issue 21363. When
countis set to0,T.sizeof * 8 - countwill always beT.sizeof * 8therefore fails compiler check here:https://github.com/dlang/dmd/blob/81f9f57257da8733cf741355524bb8a3ec9c45ce/src/dmd/dinterpret.d#L3018-L3024