merge stable #3468

MartinNowak · 2021-05-12T09:13:18Z

Fix 21857: TypeInfo_Array.compare can give wrong result when either array exceeds 2GB
Fix Issue 21363 - [REG2.094] Implementation of core.bitop.ror(x,0) is using UB
Add non-posix search for dlsym

…rray exceeds 2GB

… using UB This is a quick fix to Issue 21363. When `count` is set to `0`, `T.sizeof * 8 - count` will always be `T.sizeof * 8` therefore fails compiler check here: https://github.com/dlang/dmd/blob/81f9f57257da8733cf741355524bb8a3ec9c45ce/src/dmd/dinterpret.d#L3018-L3024

dlang-bot · 2021-05-12T09:13:21Z

Thanks for your pull request, @MartinNowak!

Auto-close	Bugzilla	Severity	Description
✓	21363	regression	[REG2.094] Implementation of core.bitop.ror(x,0) is using UB
✓	21857	normal	TypeInfo_Array.compare can give wrong result when either array exceeds 2GB

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3468"

n8sh and others added 5 commits April 27, 2021 07:10

Fix 21857: TypeInfo_Array.compare can give wrong result when either a…

e70d111

…rray exceeds 2GB

Add non-posix search for dlsym

4ea2bd8

Merge remote-tracking branch 'upstream/master' into stable

0b855b0

Merge remote-tracking branch 'upstream/stable' into merge_stable

3e00668

MartinNowak requested review from andralex, Geod24, jacob-carlborg and schveiguy as code owners May 12, 2021 09:13

dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label May 12, 2021

thewilsonator approved these changes May 12, 2021

View reviewed changes

MartinNowak merged commit bf21d1b into dlang:master May 12, 2021

MartinNowak deleted the merge_stable branch May 12, 2021 16:37

Provide feedback