This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
core/exception: Use staticError when throwing Exception #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
requested review from
CyberShadow,
jmdavis,
MartinNowak and
WalterBright
as code owners
thewilsonator
approved these changes
May 18, 2021
|
Actually I can craft one, I'll try to get to it later today. |
RazvanN7
approved these changes
May 25, 2021
Geod24
force-pushed
the
no-alloc-in-dtor-lol
branch
from
c888bec
to
9a44ce8
Compare
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + druntime#3476" |
RazvanN7
approved these changes
May 28, 2021
Geod24
force-pushed
the
no-alloc-in-dtor-lol
branch
3 times, most recently
from
b42ba17
to
31c11eb
Compare
Otherwise, an assert failure in a dtor (or anything GC-called) result in an InvalidMemoryOperationError.
Geod24
force-pushed
the
no-alloc-in-dtor-lol
branch
from
31c11eb
to
4c51564
Compare
|
Man I had forgotten how to Makefile, should be G2G now. |
|
Didn't realize there was an issue number for this: https://issues.dlang.org/show_bug.cgi?id=7349 |
|
This PR apparently introduced a regression: https://issues.dlang.org/show_bug.cgi?id=22616 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, an assert failure in a dtor (or anything GC-called) result in an InvalidMemoryOperationError.