This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix 22126 - Don't print overlapped fields with -checkaction=context #3522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonlightSentinel
requested review from
andralex,
MartinNowak,
schveiguy and
wilzbach
as code owners
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3522" |
Detect overlapped fields by checking the offsets of adjacent members. Those are replaced by a placeholder because we cannot determine wich of the overlapped fields is valid (if any).
MoonlightSentinel
force-pushed
the
checkaction/overlapped-fields
branch
from
5a9e3dd
to
9b3989c
Compare
thewilsonator
approved these changes
Jul 24, 2021
Geod24
reviewed
Jul 25, 2021
| } | ||
| } | ||
|
|
||
| test(S(1.0), S(2.0), "S(<overlapped field>, <overlapped field>) != S(<overlapped field>, <overlapped field>)"); |
There was a problem hiding this comment.
Shouldn't this be <overlapped field> ? As in, print only one entry per union ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect overlapped fields by checking the offsets of adjacent members. Those are replaced by a placeholder because we cannot determine wich of the overlapped fields is valid (if any).
This currently requires more CTFE for each instantiantion of
formatMembers. The overlap detection could be done at runtime by embedding theoffsetsarray. But this could create unusedminiFormatinstantions if they are only required by overlapped fields. Not sure which approach is preferrable...