Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix 22300 - Use reinterpreting cast for shared types during CTFE #3594

Merged
merged 1 commit into from Oct 20, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

Using the same method for compile- and runtime was enabled by
dlang/dmd#13203. Using a reinterpreting cast avoids any potentially
calling into user-defined opCast methods which might reject the cast.

Using the same method for compile- and runtime was enabled by
dlang/dmd#13203. Using a reinterpreting cast avoids any potentially
calling into user-defined `opCast` methods which might reject the cast.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22300 regression [REG 2.098-rc.2] `-checkaction=context` of a `shared` type with an `opCast` fails to compile

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3594"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Oct 20, 2021
@MoonlightSentinel MoonlightSentinel changed the title purge changelog Fix 22300 - Use reinterpreting cast for shared types during CTFE Oct 20, 2021
@dlang-bot dlang-bot merged commit e8121cc into dlang:stable Oct 20, 2021
@MoonlightSentinel MoonlightSentinel deleted the checkaction/shared-opcast branch October 20, 2021 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
3 participants