Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Remove external reference to rndtonl. #3676

Merged
merged 1 commit into from Jan 17, 2022
Merged

Conversation

ibara
Copy link
Contributor

@ibara ibara commented Jan 17, 2022

It was removed in dlang/phobos@b4f675f
Fix Issue 22683 - core.math.rndtonl can't be linked

@ibara ibara requested a review from ibuclaw as a code owner January 17, 2022 00:21
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ibara! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22683 normal core.math.rndtonl can't be linked

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3676"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jan 17, 2022
It was removed in dlang/phobos@b4f675f
Fix Issue 22683 - core.math.rndtonl can't be linked
@dlang-bot dlang-bot merged commit 9c23698 into dlang:stable Jan 17, 2022
@ibara ibara deleted the issue22683 branch January 17, 2022 04:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
4 participants