This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
core.sys.posix.sys.mman: Split mman OS flags from C runtime functions #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3679" |
thewilsonator
approved these changes
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverse of #3678. All mman.h flags are tied to the OS, not the C runtime. Having these flags behind
CRuntime_Glibcagain breaks kFreeBSD, because the underlying kernel expects theFreeBSDflags to be passed. So all flags have been moved into OS-specific version blocks, whilst the functions are still behind C-specific versions.@Geod24 this would also fix the garbage collector on mips-musl and ppc64-musl targets, because you only had x86-specific flags declared.