This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
fix Issue 22535 - ImportC: gcc/clang math intrinsics are rejected #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3702" |
WalterBright
force-pushed
the
fix22535
branch
from
208c558
to
8083ef4
Compare
ibuclaw
reviewed
Jan 22, 2022
src/__builtins.d
Outdated
Comment on lines
47
to
59
| double __builtin_inf() { return double.infinity; } | ||
| float __builtin_inff() { return float.infinity; } | ||
| real __builtin_infl() { return real.infinity; } | ||
|
|
||
| alias __builtin_huge_val = __builtin_inf; | ||
| alias __builtin_huge_valf = __builtin_inff; | ||
| alias __builtin_huge_vall = __builtin_infl; | ||
|
|
||
| import core.stdc.math; | ||
|
|
||
| alias __builtin_fabs = core.stdc.math.fabs; | ||
| alias __builtin_fabsf = core.stdc.math.fabsf; | ||
| alias __builtin_fabsl = core.stdc.math.fabsl; |
There was a problem hiding this comment.
version(DigitalMars). @kinke how redundant are these in ldc?
There was a problem hiding this comment.
AFAICT, LDC needs these too - LDC/LLVM doesn't support any magic __builtin_* names, and I haven't found these in generated module ldc.gccbuiltins_x86 either.
There was a problem hiding this comment.
It may well do, they don't occur in ldc.gccbuiltins_x86 because we filter out things that don't belong to specifically that arch. If LLVM/Clang have these builtins they will be generic. Don't know what "arch" prefix they have though.
WalterBright
force-pushed
the
fix22535
branch
from
8083ef4
to
bdf29f5
Compare
RazvanN7
approved these changes
Jan 28, 2022
WalterBright
force-pushed
the
fix22535
branch
from
c722aca
to
e6a04f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a comprehensive list anywhere on just what all of these are. So we'll just add them piecemeal as required.