This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
add src/importc.h #3730
Merged
add src/importc.h #3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3730" |
WalterBright
force-pushed
the
importc.h
branch
from
0ed2396
to
0b6a809
Compare
|
Hmm, I thought adding it to |
WalterBright
force-pushed
the
importc.h
branch
from
0b6a809
to
1ca37f8
Compare
WalterBright
force-pushed
the
importc.h
branch
from
1ca37f8
to
9680b32
Compare
|
While I'm waiting on this, I added a fix for Issue 22721: Fix Issue 22721 - importC: some gnu builtins are rejected |
thewilsonator
approved these changes
Feb 10, 2022
|
If this fixes an issue, please update the commit message to reflect that so the bot picks it up. |
WalterBright
force-pushed
the
importc.h
branch
from
9680b32
to
11c3991
Compare
|
I found a better way to fix 22721. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImportC needs a .h file to precede all other .h files, to account for things like weird extensions. __builtins.d cannot handle it all, because it happens only after preprocessing has completed.
This will reduce the burden of ImportC having to support every nutburger C extension from the Dawn of Man in a much easier manner, usually by just adding a simple macro.
While this currently needs to be added manually, I expect it will become automatically added when dmd learns how to fork the preprocessor.