Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 21781 - Add core/sync/package.d for documentation #3836

Merged
merged 1 commit into from Jun 10, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jun 8, 2022

The ddoc text is bare, I'm not familiar with the module so I'm not writing a comprehensive description yet, but this should fix the 404 and allow you to import core.sync;.

Makefiles updated similar to #2941

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21781 minor [Oh No! Page Not Found] Links to core libs from Better C

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3836"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jun 8, 2022
@ljmf00
Copy link
Member

ljmf00 commented Jun 10, 2022

Please rebase.

@dkorpel
Copy link
Contributor Author

dkorpel commented Jun 10, 2022

I'll just merge myself since the vide-d buildkite error is an issue with vibe-d itself.

@dkorpel dkorpel merged commit 454471d into dlang:master Jun 10, 2022
@dkorpel dkorpel deleted the sync-package branch June 10, 2022 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
4 participants