This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Remove unused _Unqual from object module
#685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-merge toggled on |
| else alias T _Unqual; | ||
| } | ||
| } | ||
| private alias _Unqual(T) = typeof(cast()T.init); |
There was a problem hiding this comment.
I've been wondering about doing something like this before. Can we also use this change for Phobos?
AFAIK (didn't completely look into this yet), this will fail if T provides an "opCast":
http://d.puremagic.com/issues/show_bug.cgi?id=5747#c4
That said, if this is used only on "trivial internal types", this change should be fine (but documented as "incorrect"...)
There was a problem hiding this comment.
You're right... I posted a reverting pull #686.
yebblies
added a commit
that referenced
this pull request
Dec 10, 2013
Remove unused _Unqual from `object` module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And I discovered that
Unqualtemplate can be simplified toalias Unqual(T) = typeof(cast()T.init);.