Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

fix Issue 11666: Separate platform support into separate files #741

Closed
wants to merge 1 commit into from

Conversation

WalterBright
Copy link
Member

This is a reboot of https://github.com/D-Programming-Language/druntime/pull/731/files showing the new package organization method.

version (AArch64) public import core.sys.ucontext.aarch;
else version (ARM) public import core.sys.ucontext.arm;
else version (MIPS) public import core.sys.ucontext.mips;
else version (PPC) public import core.sys.ucontext.ppc;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PPC64?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is intended as a demonstration of what I was talking about in number 731 and 732, and as such it only copies Iain's files from PR 731. I have not vetted the contents of the files. I don't know anything about the PowerPC architectures or what the files should look like for them.

Even if this PR is not pulled, I'd like to leave it up so I can point to it and say "this is what I mean" as I have consistently failed at explaining it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any similar file in Iain's pull requests. I this isn't intended to be merged, why not just close it then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following files are pretty much identical between 731 and this PR:

generic.d, arm.d, ppc.d, aarch.d, mips.d, intel.d

@WalterBright
Copy link
Member Author

closed because I rebooted it as #744

@WalterBright WalterBright deleted the reboot731 branch March 18, 2014 02:26
@WalterBright
Copy link
Member Author

@jacob-carlborg now I see what you meant by PPC64. I fixed it in 744.

@jacob-carlborg
Copy link
Contributor

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants