Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preGenerateCommands should reparse dub.json/dub.sdl, if needed #2666

Closed
WebFreak001 opened this issue Jun 23, 2023 · 1 comment
Closed

preGenerateCommands should reparse dub.json/dub.sdl, if needed #2666

WebFreak001 opened this issue Jun 23, 2023 · 1 comment
Labels

Comments

@WebFreak001
Copy link
Member

When running preGenerateCommands, dub will already re-evaluate all the globs and variables from the dub recipe, however it will never actually re-parse the dub recipe. I think if the recipe has changed (modification time), we should also re-parse the recipe, so that more advanced use-cases that edit the recipe are possible.

Note that dub right now only considers itself, not dependencies or dependents when running preGenerateCommands, which is a limitation that keeps the implementation sane though.

@Geod24
Copy link
Member

Geod24 commented Dec 28, 2023

so that more advanced use-cases that edit the recipe are possible.

I don't see self-modifying code as an advanced use case, it's an error prone hack and I really don't think we should do that.

@Geod24 Geod24 added the wontfix label Jan 17, 2024
@Geod24 Geod24 closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants