Merge pull request #5502 from wilzbach/fix-17539

Fix Issue 17539 - std.parallellism.parallel triggers 'statement not reachable' merged-on-behalf-of: Vladimir Panteleev <github@thecybershadow.net>
dlang · Jul 4, 2017 · c065234 · c065234
2 parents d9984a3 + f3770ba
commit c065234
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/std/parallelism.d b/std/parallelism.d
@@ -3500,7 +3500,7 @@ int doSizeZeroCase(R, Delegate)(ref ParallelForeach!R p, Delegate dg)
                 {
                     res = dg(elem);
                 }
-                if (res) foreachErr();
+                if (res) break;
                 index++;
             }
         }
@@ -3516,10 +3516,11 @@ int doSizeZeroCase(R, Delegate)(ref ParallelForeach!R p, Delegate dg)
                 {
                     res = dg(elem);
                 }
-                if (res) foreachErr();
+                if (res) break;
                 index++;
             }
         }
+        if (res) foreachErr;
         return res;
     }
 }
@@ -4624,3 +4625,12 @@ version(unittest)
         arr.parallel.each!"a++";
     })));
 }
+
+// https://issues.dlang.org/show_bug.cgi?id=17539
+@system unittest
+{
+    import std.random : rndGen;
+    // ensure compilation
+    try foreach (rnd; rndGen.parallel) break;
+    catch (ParallelForeachError e) {}
+}