Merge pull request #2384 from AndrewEdwards/2.066

Cherry-picking commits from master to 2.066 branch (for RC1)

posix.mak

@@ -249,9 +249,9 @@ MAKEFILE = $(firstword $(MAKEFILE_LIST))
 
 # Main target (builds the dll on linux, too)
 ifeq (linux,$(OS))
-all : $(LIB) $(LIBSO)
+all : lib dll
 else
-all : $(LIB)
+all : lib
 endif
 
 install :
@@ -270,7 +270,7 @@ depend: $(addprefix $(ROOT)/unittest/,$(addsuffix .deps,$(D_MODULES)))
 
 .PHONY: lib dll
 lib: $(LIB)
-dll: $(LIBSO)
+dll: $(ROOT)/libphobos2.so
 
 $(ROOT)/%$(DOTOBJ): %.c
 	@[ -d $(dir $@) ] || mkdir -p $(dir $@) || [ -d $(dir $@) ]
@@ -279,10 +279,7 @@ $(ROOT)/%$(DOTOBJ): %.c
 $(LIB): $(OBJS) $(ALL_D_FILES) druntime_libs
 	$(DMD) $(DFLAGS) -lib -of$@ $(DRUNTIME) $(D_FILES) $(OBJS)
 
-$(ROOT)/libphobos2.so: $(ROOT)/$(SONAME)
-	ln -sf $(notdir $(LIBSO)) $@
-
-$(ROOT)/$(SONAME): $(LIBSO)
+$(ROOT)/libphobos2.so: $(LIBSO)
 	ln -sf $(notdir $(LIBSO)) $@
 
 $(LIBSO): override PIC:=-fPIC

std/utf.d

@@ -1134,8 +1134,8 @@ private dchar decodeImpl(bool canIndex, S)(auto ref S str, ref size_t index)
         else
            return new UTFException("Attempted to decode past the end of a string");
     }
-
-    assert(fst & 0x80);
+    if((fst & 0b1100_0000) != 0b1100_0000)
+        throw invalidUTF(); // starter must have at least 2 first bits set
     ubyte tmp = void;
     dchar d = fst; // upper control bits are masked out later
     fst <<= 1;
@@ -2020,6 +2020,14 @@ void validate(S)(in S str) @safe pure
 }
 
 
+unittest // bugzilla 12923
+{
+  assertThrown((){
+    char[3]a=[167, 133, 175];
+    validate(a[]);
+  }());
+}
+
 /* =================== Conversion to UTF8 ======================= */
 
 pure