Issue 4287 - Implement concat-assign operator for Appender. #1108
Conversation
|
Removeing trailing whitespace change and other no-changes go as separate commit. |
| private template CanPutItem(U) | ||
| { | ||
| enum bool CanPutItem = isImplicitlyConvertible!(U, T) || | ||
| isSomeChar!T && isSomeChar!U; |
There was a problem hiding this comment.
Parenthesise this as || and && have the same priorty IRC. And I think it's bogus w/o them.
Also how about add a test for appender of ints explicitly?
EDIT: checked the online spec, to my shame I've found out && has higher priority and thus evaluted first, so this is a not an issue.
There was a problem hiding this comment.
Prolly you thought about & and |, which indeed have the same priority.
There was a problem hiding this comment.
Parenthesise this as || and && have the same priorty IRC. And I think it's bogus w/o them.
The code is a cut&paste of existing template constraints. All I did was put them in a template so I can use them from both the put and opOpAssign functions to avoid code duplication.
Also how about add a test for appender of ints explicitly?
I didn't change any semantics, the operators simply forward to put functions.
This should be part of detab+toLF+strip functionality which was already discussed about. I really can't waste any of my time trying to figure out if a file is in a proper state before I start editing it, the trailing whitespace should have been caught by reviewers. |
| @@ -2219,11 +2219,28 @@ Returns the managed array. | |||
| return newext > newlength ? newext : newlength; | |||
| } | |||
|
|
|||
| private template CanPutItem(U) | |||
There was a problem hiding this comment.
canPutItem since it's a value, not a type.
|
Separated detab to its own commit and changed casing for the templates. |
|
LGTM. |
Issue 4287 - Implement concat-assign operator for Appender.
http://d.puremagic.com/issues/show_bug.cgi?id=4287