Fix issue 9583

[quickfur]

std.getopt.getopt should consume options terminator "--" as claimed by docs

[ghost]

args = args.remove(i + 1);

[andralex]

yah

[ghost]

Link to issue: http://d.puremagic.com/issues/show_bug.cgi?id=9583

[alexrp]

LGTM other than @AndrejMitrovic's comment.

[alexrp]

cc @andralex

[quickfur]

Done.

[ghost]

Hmm.. The loop is foreach (i, a ; args[1 .. $]). Is it safe to modify args length within the loop?
Edit: Or maybe that break exits the loop so it doesn't matter.

[quickfur]

Generally, I wouldn't do it, but in this case, we're breaking immediately, so I think it should be OK. (In the case of arrays, though, I think foreach actually iterates over a slice, so it should be safe -- modifying args will reallocate anyway so it won't stomp on what the loop is doing.)

[ghost]

modifying args will reallocate anyway

remove doesn't actually reallocate, it modifies the contents of the slice.

[quickfur]

Oops, you're right. Well, but I think in this case it should be OK, because we're breaking immediately. Unless you think it's better to rewrite the loop to prevent possible future breakage?

[ghost]

It should be ok since we're breaking. Anyway this pull is LGTM.

[quickfur]

Rebased.