More isAssignable/hasElaborateAssign coverage/doc #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2719,6 +2719,10 @@ unittest | |||
| defining $(D opAssign(typeof(this))) or $(D opAssign(ref typeof(this))) | |||
| for a $(D struct). (Non-struct types never have elaborate assignments.) | |||
|
|
|||
| Note: There is no correlation between $(D hasElaborateAssign) and | |||
| $(D isAssignable). Having elaborate assignement does not imply | |||
Unittest and Doc change only. Because hasElaborateAssign is an odd beast. Having maximum coverage in unittests helps detect breaking changes, as well as internally documents the workings of the function. It helps looking at the unit-tests to know how it works, without making the documentation overkill.
|
Closing because now obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittest and Doc change only.
Because hasElaborateAssign is an odd beast.
Having maximum coverage in unittests helps detect breaking changes, as well as internally documents the workings of the function. It helps looking at the unit-tests to know how it works, without making the documentation overkill.