Use FieldTypeTuple!S instead of typeof(S.tupleof).
#1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but could you maybe add a test case? |
|
No test cases - it is not a bugfix. A scan of additional |
|
Could you please make it clear that this is only a stylistic refactoring in the commit message then? "is what have to be used" sounds like if there actually was a difference in behavior. Sorry for not following up earlier, but I'm rather busy right now. |
`FieldTypeTuple` is what have to be used when searching through fields as it ignores hidden fields which we don't need here.
Replace in `std.traits.hasElaborate{CopyConstructor,Assign,Destructor}`. This is a refactoring change as hidden fields didn't affect these templates behaviour.
|
Changed commit description. |
dnadlinger
added a commit
that referenced
this pull request
Apr 23, 2013
…-of-`typeof(S.tupleof)` Use `FieldTypeTuple!S` instead of `typeof(S.tupleof)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldTypeTupleis what have to be used when searching through fields as it ignores hidden fields which we don't need here.Replace in
std.traits.hasElaborate{CopyConstructor,Assign,Destructor}.