Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fix for emplace #1629

Merged
merged 1 commit into from Oct 20, 2013
Merged

Final fix for emplace #1629

merged 1 commit into from Oct 20, 2013

Conversation

monarchdodra
Copy link
Collaborator

This should be the final fix for emplace.

It fixes support for static arrays, as well as for structs with const members. It also consolidates the code somewhat, and has even more unittests.

This should fix the new issues 11173 and 11178
http://d.puremagic.com/issues/show_bug.cgi?id=10973
http://d.puremagic.com/issues/show_bug.cgi?id=10978

@monarchdodra
Copy link
Collaborator Author

@klickverbot : With this last pull, I think emplace should be "mostly completely fixed". You've been reviewing and merging these so far. Could you review this last one?

It also simplifies and relaxes the implementation, so should still work even if/when kenji introduces his newer and "more powerful" constructors.

FYI, it addresses 10973, which is a regression I introduced, and Walter wanted either fixed or reverted for 2.064. I'm opting for the "fix" solution :)

@DmitryOlshansky
Copy link
Member

@monarchdodra you may want to link pulls to bugzilla. Usually proves to be very helpful.

dnadlinger added a commit that referenced this pull request Oct 20, 2013
@dnadlinger dnadlinger merged commit edf906b into dlang:master Oct 20, 2013
@dnadlinger
Copy link
Member

@WalterBright: One of the issues was a regression.

@WalterBright
Copy link
Member

Pulling a regression fix does not automatically pull it for 2.064. This means that these fixes can get overlooked for 2.064. They need to be cherry-picked into 2.064.

dnadlinger added a commit that referenced this pull request Oct 20, 2013
@WalterBright
Copy link
Member

I cp'd this for 2.064.

@dnadlinger
Copy link
Member

@WalterBright: This is why I pinged you. Or do you mean not closing the bugzilla issue until the relevant course of action for 2.064 has been decided on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants