std.stdio: Add File.windowsHandle, fdopen and windowsHandleOpen #1888
Conversation
| @@ -69,6 +69,8 @@ version(Windows) | |||
| /+ Waiting for druntime pull 299 | |||
| +/ | |||
| extern (C) nothrow FILE* _wfopen(in wchar* filename, in wchar* mode); | |||
|
|
|||
| import core.sys.windows.windows : HANDLE; | |||
There was a problem hiding this comment.
I'm not a fan of this, due to that dreaded selective import bug. If I use WinAPI and then try to use stdio as well, I might just get a conflict of trying to use two different HANDLE definitions.
There was a problem hiding this comment.
This works for me:
import win32.basetsd;
import std.stdio;
HANDLE h;
Maybe it was fixed?
This moves existing code from std.process to std.stdio for public use.
|
Fixed merge conflict. |
|
Anyone have more to say? @schveiguy @yebblies ? |
|
All I've got is that this should probably have a linked bug report. |
| else _close(writeFD); | ||
| throw new StdioException("Cannot open pipe"); | ||
| throw new StdioException("Error attaching pipe (" ~ e.msg ~ ")", | ||
| 0); |
There was a problem hiding this comment.
The second parameter to StdioException is the errno, which is not valid at this point (it should have been processed by the caught exception and included in its message).
There was a problem hiding this comment.
Ah. But how about this:
auto ex = new StdioException(...);
ex.line = e.line;
throw ex;IOW if there is any line info that's useful to us we could store it.
There was a problem hiding this comment.
At this point, how about we just modify .msg? Then file/line information will be preserved.
There was a problem hiding this comment.
Oh, never mind, we need to throw a StdioException.
There was a problem hiding this comment.
Hmm. There's no precedent for this, at least as far as StdioException goes. The exception is thrown in a dozen places, and none of those convey file/line information, even when that exception is thrown directly. IMHO it's better to fix this all at once separately, but since either way the exception information will always point to somewhere inside Phobos, there really isn't a strong motivation to do that. (The whole deal with passing file/line information across Exception constructors seems like a giant hack around subpar stack traces anyway.)
|
Looks good. Will wait for reply to #1888 (comment) before automerging. |
|
Auto-merge toggled on |
std.stdio: Add File.windowsHandle, fdopen and windowsHandleOpen
ghost
merged commit
|
Thanks! |
| Throws: $(D ErrnoException) in case of error. | ||
| */ | ||
| version(StdDdoc) | ||
| void windowsHandleOpen(HANDLE handle, in char[] stdioOpenmode); |
There was a problem hiding this comment.
This breaks building documentation on non-Windows platforms, because HANDLE isn't defined.
ghost
mentioned this pull request
https://d.puremagic.com/issues/show_bug.cgi?id=12142
This moves existing code from std.process to std.stdio for public use.
Cont. of #1877