Fix issue 8580 - Peek returns an invalid pointer for structs larger than Variant.size. #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return type == typeid(T) ? cast(T*) &store : null; | ||
| if(type != typeid(T)) | ||
| return null; | ||
| static if(T.sizeof <= size) |
There was a problem hiding this comment.
Keep the parens whitespace style consistent please static if (, not static if(, same goes for the if statement above it.
|
Other than the stylistic issue it looks good. |
|
Added a commit to fix the style of if statements. |
|
Can you squash it into one commit? Style commits should only appear if they apply to old code, not new code. |
…han Variant.size. Style: Add space between if and condition.
|
Done I think? Not 100% sure if I rebased it correctly, but seems to be correct. |
|
Looks good! Will automerge when the tester starts running it. Thanks. |
|
Auto-merge toggled on |
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2014
Fix issue 8580 - Peek returns an invalid pointer for structs larger than Variant.size.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://d.puremagic.com/issues/show_bug.cgi?id=8580