std.File.flush and error causes segfault after calling close #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| import std.exception : enforce, errnoEnforce; | ||
|
|
||
| enforce(isOpen, "Attempting to flush() in an unopened file"); | ||
| errnoEnforce | ||
| (.fflush(enforce(_p.handle, "Calling fflush() on an unopened file")) |
There was a problem hiding this comment.
Btw, is this second enforce now unnecessary since you added the new one?
There was a problem hiding this comment.
Yes, I think it's safe to say that isOpen => _p.handle !is null, so the second enforce can be removed.
There was a problem hiding this comment.
Thank you for your comments.
I removed the second enforce.
|
Please add a test-case. Thanks. |
|
I added unittests for Issue 12349. |
|
Auto-merge toggled on |
ghost
pushed a commit
that referenced
this pull request
Mar 12, 2014
std.File.flush and error causes segfault after calling close
ghost
merged commit
|
Thanks! |
|
Thank you. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugzilla: https://d.puremagic.com/issues/show_bug.cgi?id=12349
I also mark them as
@trusted.