Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove FPTemporary usage #2637

Merged
merged 1 commit into from
Nov 6, 2014
Merged

remove FPTemporary usage #2637

merged 1 commit into from
Nov 6, 2014

Conversation

9il
Copy link
Member

@9il 9il commented Oct 24, 2014

No description provided.

@9il 9il mentioned this pull request Oct 24, 2014
@quickfur
Copy link
Member

LGTM

@MartinNowak
Copy link
Member

There is a precision loss involved when switching from FPU to SSE instructions.

@9il
Copy link
Member Author

9il commented Oct 27, 2014

And a huge performance loss too.
If real precision is needed map!(to!real) can be used.
For complex numbers there was discussion #2536.

Also it seems that FPU is going to be deprecated by CPU manufactures.

@9il
Copy link
Member Author

9il commented Oct 27, 2014

We need not FPU but IEEE standard math in dmd for precision math.
See also: Precise fsum #2513

MartinNowak added a commit that referenced this pull request Nov 6, 2014
remove FPTemporary usage
@MartinNowak MartinNowak merged commit 5f9b77a into dlang:master Nov 6, 2014
@9il
Copy link
Member Author

9il commented Nov 6, 2014

Thanks!

@9il 9il deleted the fptemp branch November 7, 2014 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants