Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model detection on Solaris. #2757

Merged
merged 1 commit into from Nov 21, 2014
Merged

Conversation

redstar
Copy link
Contributor

@redstar redstar commented Nov 21, 2014

Uses the same command as in druntime makefile.

Uses the same command as in druntime makefile.
@quickfur
Copy link
Member

I'm no Solaris expert, but shouldn't it be isainfo -b to determine 32- vs. 64-bit platforms? AFAICT from online docs, isainfo -n only tells you the native instruction set, and the makefile doesn't seem to know how to parse that properly.

@redstar
Copy link
Contributor Author

redstar commented Nov 21, 2014

I'm no Solaris expert, too. isainfo -b returns 64, isainfo -n returns amd64. This is correctly parsed in line 61:

ifneq (,$(findstring $(uname_M),x86_64 amd64))

(I really copied it from the druntime makefile. I did not invent something new. And it works on my OpenIndiana VM.)

@quickfur
Copy link
Member

Fair enough to me. :-)

@quickfur
Copy link
Member

Auto-merge toggled on

quickfur pushed a commit that referenced this pull request Nov 21, 2014
Change model detection on Solaris.
@quickfur quickfur merged commit 93bd853 into dlang:master Nov 21, 2014
@redstar redstar deleted the solaris_make branch November 21, 2014 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants