Revert "Modify std.conv.octal to be usable at runtime" #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: parse/to does not handle underscores, but I think we can probably update it to handle them. |
|
I'm going to pull this, because I pulled the original PR, and because there is already another PR to allow the underscores. |
|
Auto-merge toggled on |
schveiguy
added a commit
that referenced
this pull request
Jun 8, 2015
…ime-octal-conv Revert "Modify std.conv.octal to be usable at runtime"
JesseKPhillips
added a commit
to JesseKPhillips/phobos
that referenced
this pull request
Jun 9, 2015
This is in response to the reverting found in pull dlang#3375. This removes a mention of being experimental and possible future deprecation of a no longer valid 0 prefix. It also mentions parse for runtime parsing of octal strings.
This was referenced Jun 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3343
I forgot that
toandparsealready do this:having 2 ways to do this, within the same module no less, is unnecessary. I'm wondering actually whether
octal(the one that uses the literal at compile time) could actually simply forward toparseinstead of having its own special mechanism.