New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 14884 - among
docs broken link to find
and canFind
#3542
Conversation
among
docs broken link to find
and canFind
Bugzilla link: https://issues.dlang.org/show_bug.cgi?id=14884 |
I'm going to wait until the doc tester is fixed before reviewing... @CyberShadow ? |
Git repository corruption, again. I nuked the submodule, maybe it'll work for a while longer. I'm on vacation right now. |
I fixed the corruption but master is still not buildable: http://dtest.thecybershadow.net/results/89405386935902ebf4b5de778365e9144e9a8a57/!base/build.log It looks like it's not fetching dmd-2.068. Not sure if this is a regression. |
I think it was broken by dlang/dlang.org#1050 I did not really understand the motivation for than change. IMHO it was the wrong fix for the problem it was trying to fix. The second change in particular had little to do with the arguments presented in the PR. |
I cloned it by invoking the make target manually, and master builds again, but this will likely come up again at the next (dot-)release. |
@CyberShadow Thanks for looking at it on your vacation! |
I think there is an issue with the documentation tester. Whenever I go to any of the pages, I get a 502 error. |
Documentation tester is up again. LGTM |
Ugh, absolute URLs to dlang.org :/ |
LGTM. Tested locally, looks great. Thanks! The absolute URL issue is outside the scope of this PR; it should be fixed in the dlang.org repo. |
Fix Issue 14884 - `among` docs broken link to `find` and `canFind`
Filed issue for the absolute URL bug: https://issues.dlang.org/show_bug.cgi?id=14963 |
Thanks. |
Fix attempt: dlang/dlang.org#1082 (Should work, but I didn't inspect every generated link for correctness.) |
No description provided.