Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 14884 - among docs broken link to find and canFind #3542

Merged
merged 1 commit into from Aug 26, 2015

Conversation

luismarques
Copy link
Contributor

No description provided.

@luismarques luismarques changed the title Fix Issue 14884 Fix Issue 14884 - among docs broken link to find and canFind Aug 10, 2015
@luismarques
Copy link
Contributor Author

Bugzilla link: https://issues.dlang.org/show_bug.cgi?id=14884

@schveiguy
Copy link
Member

I'm going to wait until the doc tester is fixed before reviewing... @CyberShadow ?

@CyberShadow
Copy link
Member

Git repository corruption, again. I nuked the submodule, maybe it'll work for a while longer. I'm on vacation right now.

@CyberShadow
Copy link
Member

I fixed the corruption but master is still not buildable:

http://dtest.thecybershadow.net/results/89405386935902ebf4b5de778365e9144e9a8a57/!base/build.log

It looks like it's not fetching dmd-2.068. Not sure if this is a regression.

@CyberShadow
Copy link
Member

I think it was broken by dlang/dlang.org#1050

I did not really understand the motivation for than change. IMHO it was the wrong fix for the problem it was trying to fix. The second change in particular had little to do with the arguments presented in the PR.

CC @andralex @MartinNowak

@CyberShadow
Copy link
Member

I cloned it by invoking the make target manually, and master builds again, but this will likely come up again at the next (dot-)release.

@schveiguy
Copy link
Member

@CyberShadow Thanks for looking at it on your vacation!

@schveiguy
Copy link
Member

I think there is an issue with the documentation tester. Whenever I go to any of the pages, I get a 502 error.

@aG0aep6G
Copy link
Contributor

Documentation tester is up again. LGTM

@CyberShadow
Copy link
Member

Ugh, absolute URLs to dlang.org :/

@quickfur
Copy link
Member

LGTM. Tested locally, looks great. Thanks!

The absolute URL issue is outside the scope of this PR; it should be fixed in the dlang.org repo.

CyberShadow added a commit that referenced this pull request Aug 26, 2015
Fix Issue 14884 - `among` docs broken link to `find` and `canFind`
@CyberShadow CyberShadow merged commit 8f5a37f into dlang:master Aug 26, 2015
@quickfur
Copy link
Member

Filed issue for the absolute URL bug: https://issues.dlang.org/show_bug.cgi?id=14963

@CyberShadow
Copy link
Member

Thanks.

@quickfur
Copy link
Member

Fix attempt: dlang/dlang.org#1082

(Should work, but I didn't inspect every generated link for correctness.)

@luismarques luismarques deleted the fix_issue_14884 branch August 28, 2015 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants