Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward std.math intrinsics to core.math #3599

Merged
merged 1 commit into from Aug 30, 2015

Conversation

yebblies
Copy link
Member

No description provided.

@yebblies
Copy link
Member Author

All green, ready to go. I avoided using aliases for this to prevent the generated documentation from regressing.

This is a partial fix for Issue 4541 - Intrinsic functions do not have pointers

@DmitryOlshansky
Copy link
Member

I avoided using aliases for this to prevent the generated documentation from regressing.

pragma(inline, true) then ?

@yebblies
Copy link
Member Author

Is it really necessary?

@DmitryOlshansky
Copy link
Member

Is it really necessary?

A look at disassembly would answer that I guess. I just don't want to silently regress numerics performance.

@yebblies
Copy link
Member Author

Ok, done.

@ibuclaw
Copy link
Member

ibuclaw commented Aug 30, 2015

I just don't want to silently regress numerics performance.

Not that I want to make the tongue in cheek response, but they are already silently regressed on x86 by forcing operations to be done in the highest precision. ;-)

@DmitryOlshansky
Copy link
Member

but they are already silently regressed on x86 by forcing operations to be done in the highest precision. ;-)

No point destroying them further then ;)

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

DmitryOlshansky added a commit that referenced this pull request Aug 30, 2015
Forward std.math intrinsics to core.math
@DmitryOlshansky DmitryOlshansky merged commit 7aaf7c7 into dlang:master Aug 30, 2015
@yebblies yebblies deleted the stdintrinsic branch August 30, 2015 10:48
@yebblies
Copy link
Member Author

Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants