fixed issue 15639 - allocator.make enables abstract class instantiation

[ghost]

No description provided.

[dlang-bot]

Fix	Bugzilla	Description
✓	15639	std.experimental.allocator enables abstract class instantiation

[JackStouffer]

LGTM

[schveiguy]

Changelog

Please put changelog entries into changelog.dd in phobos root directory. These will be merged and put into main changelog on release.

[ghost]

Ok actually I was not sure of the way to do but so far not merged so I'll wait.

[MetaLang]

@schveiguy Can you take a look at #4022 as well?

[ghost]

@schveiguy updated #4023, Is it like that that changelog should be updated ?

[schveiguy]

Oh, I apologize completely! I saw your message comment about the changelog, and not thinking, I assumed you expected that that comment to be included somehow in the changelog. I'm honestly doing more harm than good today :(

changelog.dd is for changes that need further explanation (e.g. new features or behavior changes). Bug fixes will automatically be included as long as there is a bugzilla issue that is fixed during the release cycle (@MartinNowak I believe has a script to do that). I realize now, this (and the other update) are bugs that have corresponding bugzilla entries. So the changelog.dd update is not necessary (I think). I don't know if it's helpful to have them listed there, as @MartinNowak is the one to update the change log.

So sorry to waste your time with that! I will shut up now...

[schveiguy]

LGTM

[schveiguy]

Auto-merge toggled on

[schuetzm]

Stupid question - this seems the wrong place to fix the problem... Shouldn't emplace() itself be changed to reject abstract classes?

[ghost]

Yes It's also allowed and shouldn't !

[ghost]

A BR must be created so that it'll be referenced in the changelog, but actually since emplace() is an old function there's a risk, even if very small, of breakage.

https://issues.dlang.org/show_bug.cgi?id=15772

[ghost]

fix proposed in #4057