Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 12367 - std.regex: Recognize (?# ... ) comment syntax #4159

Merged
merged 2 commits into from
Apr 11, 2016
Merged

Fix issue 12367 - std.regex: Recognize (?# ... ) comment syntax #4159

merged 2 commits into from
Apr 11, 2016

Conversation

DmitryOlshansky
Copy link
Member

Adds hackish comment syntax that's supported by a lot of regex engines.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
✓ 12367 std.regex: Recognize (?# ... ) comment syntax

@9il 9il added the regex label Apr 7, 2016
@9il
Copy link
Member

9il commented Apr 7, 2016

Could you please update the docs?

@DmitryOlshansky
Copy link
Member Author

Could you please update the docs?

Added a mention in the docs and the changelog

@9il
Copy link
Member

9il commented Apr 10, 2016

Error - file 'std/regex/package.d' contains trailing whitespace at line 131

@DmitryOlshansky
Copy link
Member Author

Error - file 'std/regex/package.d' contains trailing whitespace at line 131

Fixed

@9il
Copy link
Member

9il commented Apr 11, 2016

Auto-merge toggled on

@9il 9il merged commit b4f0478 into dlang:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
regex
Projects
None yet
Milestone
No milestone
3 participants
@DmitryOlshansky @dlang-bot @9il