fix tempCString() to follow strict scope rules #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WalterBright, thanks for your PR! By analyzing the annotation information on this pull request, we identified @denis-sh, @wilzbach and @9rnsr to be potential reviewers. @denis-sh: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
WalterBright
force-pushed
the
cstring-scope
branch
from
00295e7
to
390946a
Compare
Current coverage is 88.78% (diff: 92.85%)@@ master #4746 diff @@
==========================================
Files 121 121
Lines 74159 74156 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 65844 65841 -3
Misses 8315 8315
Partials 0 0
|
WalterBright
force-pushed
the
cstring-scope
branch
from
390946a
to
9c5401c
Compare
| if (!ptr) | ||
| onOutOfMemoryError(); | ||
| memcpy(ptr, res.ptr, i * To.sizeof); | ||
| return ptr[0 .. newlen]; | ||
| } | ||
| else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is not to conflate pointers-to-stack with pointers-to-heap, otherwise the compiler gets concerned that the former escapes.
This is blocking dlang/dmd#5972
As this is a blocker, please don't delay reviewing/pulling it.